Merge frontmatter when inserting template#715
Open
meeIbrahim wants to merge 4 commits intoepwalsh:mainfrom
Open
Merge frontmatter when inserting template#715meeIbrahim wants to merge 4 commits intoepwalsh:mainfrom
meeIbrahim wants to merge 4 commits intoepwalsh:mainfrom
Conversation
Author
|
Need to cater for disable_frontmatter. Converting to draft |
Author
|
@epwalsh We might be able to improve this merging behavior further if we change some code in the Client. Let me know if you think this is enough or should i give this a re-go |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue: #714
Changed insert template method to merge frontmatter of template into the existing note if note already has frontmatter